Use sys_pgcon for long-term advisory locks #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Feb 9, 2025
msullivan
reviewed
Feb 10, 2025
edb/server/protocol/ai_ext.py
Outdated
Comment on lines
390
to
391
| await pgconn.sql_execute(b"ROLLBACK TO SAVEPOINT " + sp) | ||
| async with tenant.use_sys_pgcon() as syscon: |
There was a problem hiding this comment.
What is the try-lock for?
And couldn't it get taken by another connection after the ROLLBACK but before the lock?
Is that a problem?
There was a problem hiding this comment.
What is the try-lock for?
It checks if the lock is being held by another worker (through sys_pgcon). We cannot acquire this lock directly in sys_pgcon because, say if another worker is already holding this lock through sys_pgcon, re-acquiring the lock will not block (or fail with the try_* method) from the same sys_pgcon session.
And couldn't it get taken by another connection after the ROLLBACK but before the lock?
That's guaranteed not to happen by the outter/first lock, unless other code misused the same advisory lock ID.
msullivan
added
backported-6.x
msullivan
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Fixes the issue of advisory locks getting leaked back to the connection pool. * Fixes the `test_ext_ai_indexing_*` failures in CI.
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
* Fixes the issue of advisory locks getting leaked back to the connection pool. * Fixes the `test_ext_ai_indexing_*` failures in CI.
msullivan
added
backported-5.x
msullivan
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Fixes the issue of advisory locks getting leaked back to the connection pool. * Fixes the `test_ext_ai_indexing_*` failures in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_ext_ai_indexing_*failures in CI.Refs #7183, sample run