Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit instance configs matching their defaults in DESCRIBE INSTANCE CONFIG #8316

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

msullivan
Copy link
Member

Doing this can cause some problems with dumps---they will appear in dumps,
even though they may not be configurable on cloud.

Addresses part of #7332.

…NCE CONFIG

Doing this can cause some problems with dumps---they will appear in dumps,
even though they may not be configurable on cloud.

Addresses part of #7332.
@msullivan msullivan requested review from elprans and fantix February 6, 2025 21:17
@msullivan msullivan added the to-backport-6.x PRs that *should* be backported to 6.x label Feb 6, 2025
@msullivan msullivan merged commit efe3a0f into master Feb 6, 2025
23 checks passed
@msullivan msullivan deleted the describe-instance branch February 6, 2025 21:41
@msullivan msullivan added backported-6.x PRs that *have* been backported to 6.x and removed to-backport-6.x PRs that *should* be backported to 6.x labels Feb 6, 2025
msullivan added a commit that referenced this pull request Feb 6, 2025
…NCE CONFIG (#8316)

Doing this can cause some problems with dumps---they will appear in
dumps,
even though they may not be configurable on cloud.

Addresses part of #7332.
deepbuzin pushed a commit that referenced this pull request Feb 18, 2025
…NCE CONFIG (#8316)

Doing this can cause some problems with dumps---they will appear in
dumps,
even though they may not be configurable on cloud.

Addresses part of #7332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-6.x PRs that *have* been backported to 6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants