Add testing for the patch system #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
added a commit
that referenced
this pull request
Feb 5, 2025
It didn't work if it actually had any schema to repair. Testing this is annoying because it only comes up in the presence of bugs or patches, basically. It will get exercised by #8303.
msullivan
force-pushed
the
A-inplace-patches
branch
2 times, most recently
from
c595f7a to
1bd1ce9
Compare
We test actually applying all of our real patches on release branches, but this adds testing on the master branch of the patch system itself. It works in basically the same way as our inplace upgrade tests: by creating a database, and then applying a diff that makes some synthetic testing changes to the server/compiler. I (re)discovered some various frustrating limitations of the patch system while doing this, but haven't fixed those yet. Fixes #5804.
msullivan
force-pushed
the
A-inplace-patches
branch
from
1bd1ce9 to
1622d1b
Compare
elprans
approved these changes
Feb 5, 2025
msullivan
added a commit
that referenced
this pull request
Feb 5, 2025
It didn't work if it actually had any schema to repair. Testing this is annoying because it only comes up in the presence of bugs or patches, basically. It will get exercised by #8303.
msullivan
added a commit
that referenced
this pull request
Feb 5, 2025
It didn't work if it actually had any schema to repair. Testing this is annoying because it only comes up in the presence of bugs or patches, basically. It will get exercised by #8303.
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
It didn't work if it actually had any schema to repair. Testing this is annoying because it only comes up in the presence of bugs or patches, basically. It will get exercised by #8303.
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
We test actually applying all of our real patches on release branches, but this adds testing on the master branch of the patch system itself. It works in basically the same way as our inplace upgrade tests: by creating a database, and then applying a diff that makes some synthetic testing changes to the server/compiler. I (re)discovered some various frustrating limitations of the patch system while doing this, but haven't fixed those yet. Fixes #5804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test actually applying all of our real patches on release branches,
but this adds testing on the master branch of the patch system itself.
It works in basically the same way as our inplace upgrade tests: by
creating a database, and then applying a diff that makes some
synthetic testing changes to the server/compiler.
I (re)discovered some various frustrating limitations of the patch system
while doing this, but haven't fixed those yet.
Fixes #5804.