Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure config spec-dependent functions are regened when grafting testmode #8283

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Make sure config spec-dependent functions are regened when grafting testmode #8283

merged 1 commit into from
Jan 31, 2025

Conversation

elprans
Copy link
Member

@elprans elprans commented Jan 31, 2025

When adding remapping machinery in #8275 I forgot that _testmode
config gets grafted onto bootstrap cache shipped in production builds.
Rectify that.

@elprans
Make sure config spec-dependent functions are regened when grafting t…
07d8613 
…estmode

When adding remapping machinery in #8275 I forgot that `_testmode`
config gets grafted onto bootstrap cache shipped in production builds.
Rectify that.
@elprans elprans requested review from msullivan and fantix January 31, 2025 19:18
@elprans elprans merged commit 0676b5e into master Jan 31, 2025
66 of 67 checks passed
@elprans elprans deleted the regen-cfg-funcs-on-testmode-graft branch January 31, 2025 20:58
@msullivan msullivan added the to-backport-6.x PRs that *should* be backported to 6.x label Feb 4, 2025
msullivan pushed a commit that referenced this pull request Feb 4, 2025
@elprans @msullivan
Make sure config spec-dependent functions are regened when grafting t…
7cdfe0e 
…estmode (#8283)

When adding remapping machinery in #8275 I forgot that `_testmode`
config gets grafted onto bootstrap cache shipped in production builds.
Rectify that.
@msullivan msullivan added backported-6.x PRs that *have* been backported to 6.x and removed to-backport-6.x PRs that *should* be backported to 6.x labels Feb 4, 2025
msullivan pushed a commit that referenced this pull request Feb 4, 2025
@elprans @msullivan
Make sure config spec-dependent functions are regened when grafting t…
a58544e 
…estmode (#8283)

When adding remapping machinery in #8275 I forgot that `_testmode`
config gets grafted onto bootstrap cache shipped in production builds.
Rectify that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

@fantix fantix Awaiting requested review from fantix

Assignees
No one assigned
Labels
backported-6.x PRs that *have* been backported to 6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elprans @msullivan