Fix pg_constraint oid duplication #8166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple of our invested constraints were being given the same oid which caused problems. One specific problem was generating bogus pgdumps, which annoyingly mostly only showed up in inplace-upgrade tests: https://github.com/edgedb/edgedb/actions/runs/12442350513/job/34740389082?pr=8159 The problem was that pg_get_constraintdef was returning a constraint definition for the "wrong" object; the defining query would return 3 rows, and postgres silently returns the first. Fix this by adding some bits to the oid separate from the uuid of the link, and test that the fix works by putting the body of pg_get_constraintdef into a subquery. This hopefully will unblock #8159.
elprans
approved these changes
Jan 2, 2025
msullivan
added a commit
that referenced
this pull request
Jan 3, 2025
Multiple of our invested constraints were being given the same oid which caused problems. One specific problem was generating bogus pgdumps, which annoyingly mostly only showed up in inplace-upgrade tests: https://github.com/edgedb/edgedb/actions/runs/12442350513/job/34740389082?pr=8159 The problem was that pg_get_constraintdef was returning a constraint definition for the "wrong" object; the defining query would return 3 rows, and postgres silently returns the first. Fix this by adding some bits to the oid separate from the uuid of the link, and test that the fix works by putting the body of pg_get_constraintdef into a subquery. This hopefully will unblock #8159.
msullivan
added a commit
that referenced
this pull request
Jan 3, 2025
Multiple of our invested constraints were being given the same oid which caused problems. One specific problem was generating bogus pgdumps, which annoyingly mostly only showed up in inplace-upgrade tests: https://github.com/edgedb/edgedb/actions/runs/12442350513/job/34740389082?pr=8159 The problem was that pg_get_constraintdef was returning a constraint definition for the "wrong" object; the defining query would return 3 rows, and postgres silently returns the first. Fix this by adding some bits to the oid separate from the uuid of the link, and test that the fix works by putting the body of pg_get_constraintdef into a subquery. This hopefully will unblock #8159.
msullivan
added
backported-6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple of our invested constraints were being given the same oid
which caused problems.
One specific problem was generating bogus pgdumps, which annoyingly
mostly only showed up in inplace-upgrade tests:
https://github.com/edgedb/edgedb/actions/runs/12442350513/job/34740389082?pr=8159
The problem was that pg_get_constraintdef was returning a constraint
definition for the "wrong" object; the defining query would return 3
rows, and postgres silently returns the first.
Fix this by adding some bits to the oid separate from the uuid of the
link, and test that the fix works by putting the body of
pg_get_constraintdef into a subquery.
This hopefully will unblock #8159.