doc: add docs for sys::QueryStats #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beerose
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Do the plan related things refer to Postgres backend exclusively? Will QueryStats collect information about the edgeDB-server perspective in the future?
There was a problem hiding this comment.
Do the
planrelated things refer to Postgres backend exclusively?
Currently yes, all mutating values in this view are collected in the backend (postgres).
Will QueryStats collect information about the edgeDB-server perspective in the future?
Yes, I think so. The infra is ready for EdgeDB server to inject extra per-query info like EdgeQL compilation time, I/O time, etc.
There was a problem hiding this comment.
Very nice, thanks! I look forward to that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly translated by the free version of GitHub Copilot from the source EdgeQL. I double-checked and added a few lines, but I haven't run a build to verify the doc syntax etc.