Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to cover modifying functions. #8106

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Dec 11, 2024

No description provided.

Comment on lines 62 to 63
Unlike other functions, the arguments of modifying functions **must** have a
:ref:`cardinality <_ref_reference_cardinality>` of ``One``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practical question: if some property that you're trying to insert or update is multi, does that mean you'll have to pass it as an array and unpack it? Maybe we should show this as an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a more general section on passing in sets as arguments as well.

Comment on lines 56 to 58
Volatile and modifying functions are not allowed in computed properties
defined in schema. This means that, for example, your schema-defined computed
property cannot call :eql:func:`datetime_current`, but it *can* call
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a link to the corresponding docs for modyfing functions so that it's clear what we refer to?

Copy link
Contributor Author

@dnwpark dnwpark Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked the volatility reference page and changed phrase to refer to expressions in general.

}
);

then the following queries are valid:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
then the following queries are valid:
Then the following queries are valid:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure that's customary, since it's technically the continuation of the previous sentence.

@dnwpark dnwpark force-pushed the docs-function-dml branch from b44ce89 to e246a6d Compare January 8, 2025 22:00
@dnwpark dnwpark force-pushed the docs-function-dml branch from d72ed80 to 6fe34ef Compare January 9, 2025 22:27
@dnwpark dnwpark merged commit deb1546 into master Jan 9, 2025
24 checks passed
@dnwpark dnwpark deleted the docs-function-dml branch January 9, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants