-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to cover modifying functions. #8106
Conversation
bc310ba
to
7fc908e
Compare
docs/datamodel/functions.rst
Outdated
Unlike other functions, the arguments of modifying functions **must** have a | ||
:ref:`cardinality <_ref_reference_cardinality>` of ``One``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Practical question: if some property that you're trying to insert or update is multi
, does that mean you'll have to pass it as an array and unpack it? Maybe we should show this as an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a more general section on passing in sets as arguments as well.
docs/datamodel/computeds.rst
Outdated
Volatile and modifying functions are not allowed in computed properties | ||
defined in schema. This means that, for example, your schema-defined computed | ||
property cannot call :eql:func:`datetime_current`, but it *can* call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a link to the corresponding docs for modyfing functions so that it's clear what we refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked the volatility reference page and changed phrase to refer to expressions in general.
} | ||
); | ||
|
||
then the following queries are valid: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then the following queries are valid: | |
Then the following queries are valid: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure that's customary, since it's technically the continuation of the previous sentence.
Co-authored-by: Aleksandra <[email protected]>
b44ce89
to
e246a6d
Compare
d72ed80
to
6fe34ef
Compare
No description provided.