Send dimensions & user args to embedding models #8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diksipav
commented
Dec 10, 2024
| @@ -2225,6 +2232,9 @@ async def _handle_embeddings_request( | |||
| raise TypeError( | |||
| 'missing or empty required "model" value in request') | |||
|
|
|||
| shortening = body.get("dimensions") | |||
There was a problem hiding this comment.
I'd like above on line 2225 to use inputs = body.get("inputs") and to expect inputs from the clients, but this is a breaking change so probably we wanna leave it as input.
Is it ok to accept both input or inputs and to provide deprecated for input?
There was a problem hiding this comment.
Sure, accept both, but throw an error when both are specified.
diksipav
force-pushed
the
update-ai-ext-embedding-api
branch
from
b0a79a1 to
3de2838
Compare
elprans
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If provided, send dimensions and user in embedding requests.