Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigonometry functions. #8071

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Add trigonometry functions. #8071

merged 5 commits into from
Dec 5, 2024

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Dec 4, 2024

Add pi, acos, asin, atan, atan2, cos, cot, sin, tan.

Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

edb/buildmeta.py Outdated
@@ -60,7 +60,7 @@
# The merge conflict there is a nice reminder that you probably need
# to write a patch in edb/pgsql/patches.py, and then you should preserve
# the old value.
EDGEDB_CATALOG_VERSION = 2024_11_26_22_08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the catalog again, since it's already been updated to 03

msullivan added a commit that referenced this pull request Dec 4, 2024
Otherwise, when the catalog changes but nothing else triggers a cache
invalidation, we will fail to rebuild and the schema names will be
wrong.

(See CI failures in #8071.)
msullivan added a commit that referenced this pull request Dec 4, 2024
Otherwise, when the catalog changes but nothing else triggers a cache
invalidation, we will fail to rebuild and the schema names will be
wrong.

(See CI failures in #8071.)
@dnwpark dnwpark merged commit 4cb730b into master Dec 5, 2024
24 checks passed
@dnwpark dnwpark deleted the trig-funcs branch December 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants