-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trigonometry functions. #8071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
edb/buildmeta.py
Outdated
@@ -60,7 +60,7 @@ | |||
# The merge conflict there is a nice reminder that you probably need | |||
# to write a patch in edb/pgsql/patches.py, and then you should preserve | |||
# the old value. | |||
EDGEDB_CATALOG_VERSION = 2024_11_26_22_08 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump the catalog again, since it's already been updated to 03
msullivan
added a commit
that referenced
this pull request
Dec 4, 2024
Otherwise, when the catalog changes but nothing else triggers a cache invalidation, we will fail to rebuild and the schema names will be wrong. (See CI failures in #8071.)
msullivan
added a commit
that referenced
this pull request
Dec 4, 2024
Otherwise, when the catalog changes but nothing else triggers a cache invalidation, we will fail to rebuild and the schema names will be wrong. (See CI failures in #8071.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pi
,acos
,asin
,atan
,atan2
,cos
,cot
,sin
,tan
.