Tweak compilation cache for SQL queries #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20bd5351b77d801f2ad71fca4c570949ef3e6b8e.
|
Any idea what's going on with the test failure? |
|
We were rejecting multi-statement queries in execute, after trying to fetch type descriptors from PostgreSQL. |
msullivan
approved these changes
Dec 4, 2024
Comment on lines
+405
to
+416
| @contextlib.contextmanager | ||
| def assertChange( | ||
| self, measure_fn: typing.Callable[[], int | float], | ||
| expected_change: int | float | ||
| ): | ||
| before = measure_fn() | ||
| try: | ||
| yield | ||
| finally: | ||
| after = measure_fn() | ||
| change = after - before | ||
| self.assertEqual(expected_change, change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryUnit.cachableset to False for sql-over-edgedb-protocol,NormalizedSourceas cache key, which includes extracted constants, which defeats (most) of the purpose of cachingCommits: