Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ALTER ROLE edgedb refer to admin if edgedb doesn't exist #8048

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

msullivan
Copy link
Member

This makes mirrors the logic for logins and avoid breaking setup
scripts, such as those in our client test suites and possibly in some
user suites.

Follow-up to #8010.
Makes geldata/gel-python#550 unnecessary.

This makes mirrors the logic for logins and avoid breaking setup
scripts, such as those in our client test suites and possibly in some
user suites.

Follow-up to #8010.
Makes geldata/gel-python#550 unnecessary.
@msullivan msullivan merged commit 0504ebe into master Nov 28, 2024
23 checks passed
@msullivan msullivan deleted the role-fallback branch November 28, 2024 02:34
@aljazerzen
Copy link
Contributor

After this got merged, I'm no longer able to connect to edgedb over postgresql protocol using this command:

$ psql "postgres://edgedb@localhost:5656?sslmode=require"
psql: error: connection to server at "localhost" (::1), port 5656 failed: FATAL:  authentication failed

... but user admin works:

$ psql "postgres://admin@localhost:5656?sslmode=require"
psql (17.0, server 13.9)
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, compression: off, ALPN: none)
Type "help" for help.

edgedb=#

@msullivan
Copy link
Member Author

After this got merged, I'm no longer able to connect to edgedb over postgresql protocol using this command:

$ psql "postgres://edgedb@localhost:5656?sslmode=require"
psql: error: connection to server at "localhost" (::1), port 5656 failed: FATAL:  authentication failed

... but user admin works:

$ psql "postgres://admin@localhost:5656?sslmode=require"
psql (17.0, server 13.9)
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, compression: off, ALPN: none)
Type "help" for help.

edgedb=#

Fixed this in #8057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants