Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unsupported error message over SQL adapter #7995

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Improve unsupported error message over SQL adapter #7995

merged 2 commits into from
Nov 21, 2024

Conversation

aljazerzen
Copy link
Contributor

No description provided.

elprans
elprans approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than it was, but I'd still prefer if we eventually made a proper dispatch over statement AST like we do for status tags for EdgeQL statements.

@aljazerzen aljazerzen merged commit 41afb84 into master Nov 21, 2024
24 checks passed
@aljazerzen aljazerzen deleted the sql-error-messages branch November 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans elprans approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljazerzen @elprans