Update ai ext #7963
Merged
Update ai ext #7963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Nov 6, 2024
diksipav
force-pushed
the
update-ai-ext
branch
from
b71927d to
149f8b0
Compare
diksipav
commented
Nov 7, 2024
elprans
reviewed
Nov 11, 2024
elprans
reviewed
Nov 11, 2024
elprans
reviewed
Nov 11, 2024
elprans
reviewed
Nov 11, 2024
elprans
reviewed
Nov 11, 2024
elprans
reviewed
Nov 14, 2024
edb/server/protocol/ai_ext.py
Outdated
| "objects" | ||
| "prompt.custom must be a list, where each element is \ | ||
| one of the following types: \ | ||
| - EdgeDBSystemMessage: { role, content } \ |
There was a problem hiding this comment.
Where does EdgeDBSystemMessage and others come from? Seems a bit confusing since those aren't actual keys in input?
There was a problem hiding this comment.
the type EdgeDBSystemMessage etc are defined in the js vercel provider and js ai binding,
they represent the messages user provides, like the chat history
There was a problem hiding this comment.
Yeah, but this is server-side. If one interacts with the API via another SDK the errors would not make sense.
There was a problem hiding this comment.
I get it, I believe the error is better now. It should be understandable enough for everyone.
dnwpark
reviewed
Nov 18, 2024
mmastrac
added a commit
to mmastrac/edgedb
that referenced
this pull request
Nov 19, 2024
dnwpark
approved these changes
Nov 19, 2024
elprans
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add up to date models to the
ai.edgeql.Update ai ext:
Tested basic rag queries and queries that involve function calling with OpenAI, Mistral and Anthropic.
Questions about the country are using function calling.
https://github.com/user-attachments/assets/68d89295-1082-4573-a194-f218e709a154