Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Rust toolchain issues #7660

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Conversation

mmastrac
Copy link
Contributor

No description provided.

@mmastrac mmastrac requested a review from fantix August 19, 2024 17:43
Comment on lines 12 to 14
- name: Install Rust toolchain
uses: dsherret/rust-toolchain-file@v1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll also work if we move this to tests.tpl.yml at line 87:

diff --git a/.github/workflows.src/tests.tpl.yml b/.github/workflows.src/tests.tpl.yml
index 032de7c44..940f20e86 100644
--- a/.github/workflows.src/tests.tpl.yml
+++ b/.github/workflows.src/tests.tpl.yml
@@ -84,6 +84,9 @@ jobs:
     steps:
     <<- restore_cache() >>

+    - name: Install Rust toolchain
+      uses: dsherret/rust-toolchain-file@v1
+
     # Run the test

     - name: Test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this one now...

@mmastrac mmastrac merged commit a8e33f6 into geldata:master Aug 19, 2024
24 checks passed
@mmastrac mmastrac deleted the rust_toolchain_fix branch August 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants