Enforce rustfmt and clippy on all Rust code #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any specific reason for that? It isn't dead code, we use it here. |
Ah, I missed that it was used. I can restore that code. |
elprans
approved these changes
Aug 16, 2024
mmastrac
force-pushed
the
modernize_rust
branch
from
d39e1af to
16b7659
Compare
fantix
reviewed
Aug 21, 2024
| @@ -107,3 +107,54 @@ def test_cqa_mypy(self): | |||
| output += '\n\n' + ex.stderr.decode() | |||
| raise AssertionError( | |||
| f'mypy validation failed:\n{output}') from None | |||
|
|
|||
| def test_clippy(self): | |||
There was a problem hiding this comment.
These 2 tests are failing on nightlies (where we run tests with released binary):
https://github.com/edgedb/edgedb/actions/runs/10481913983/job/29032928532
You can test this by pushing code into a branch in the main repo and manually triggering the Dry Run CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts enforcing rustfmt and clippy on all Rust code, and adds a test to
tests/test_sourcecode.pyto test this at build time.Thegraphql-rewritecodebase is removed as part of this work -- we can recover it from git history if we revisit it in the future.