Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust connpool: Implement an explicit reconnection phase #7584

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mmastrac
Copy link
Contributor

We want to track reconnections for QoS and algorithm purposes -- we want to account for the time spend disconnecting and reconnecting when calculating the expense of switching connections.

@mmastrac mmastrac changed the title Implement an explicit reconnection phase Rust connpool: Implement an explicit reconnection phase Jul 19, 2024
@mmastrac mmastrac requested review from fantix and a team July 19, 2024 20:15
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmastrac for the explanation in PM! So basically:

  • Each connect and each reconnect has a matching disconnect event

  • The calculataion for how long it takes to reconnect is just the greatest of

    1. the actual average reconnection time (which is a disconnect + connect) and
    2. the average times to connect and disconnect.

    This just ensures we can get that number even when our stats are sparse. Eventually, sum(avg(connect) + avg(disconnect) should roughly equal avg(reconnect) once there's enough data.

@mmastrac mmastrac merged commit 26ec907 into geldata:master Jul 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants