Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inheritance CTEs instead of views in SQL resolver #7494

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Use inheritance CTEs instead of views in SQL resolver #7494

merged 3 commits into from
Jun 27, 2024

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Jun 26, 2024 •
edited
Loading

  • extract code for creating VIEWS from delta.py into inheritance.py and adapt it to construct pgast instead of strings,
  • use that asts as inheritance CTEs in resolver,
  • cleanup,

Prerequisite for #7455

Ref #7410

@aljazerzen aljazerzen changed the title sql inh views Use inheritance CTEs instead of views in SQL resolver Jun 26, 2024
@aljazerzen aljazerzen changed the base branch from master to refactor-resolver-context June 26, 2024 19:16
@aljazerzen aljazerzen requested a review from msullivan June 26, 2024 19:19
msullivan
msullivan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

Base automatically changed from refactor-resolver-context to master June 26, 2024 21:37
@aljazerzen aljazerzen merged commit 3868fd3 into master Jun 27, 2024
24 checks passed
@aljazerzen aljazerzen deleted the sql-inh-views branch June 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljazerzen @msullivan