Make overloading a link when omitting link keyword work #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlterUnknownPointer works by converting the AST node into an operation on the relevant concrete pointer sort. It always converted into an Alter, though, which meant that the overload case, where AlterObject._cmd_tree_from_ast is called with a Create node, didn't work right. Fixes #6716.
msullivan
changed the title
link keyword work
|
@msullivan Any chance that your PR will fix this too? Thanks for working on this! EdgeDB is so much fun to use. |
elprans
approved these changes
Jan 23, 2024
aljazerzen
pushed a commit
that referenced
this pull request
Jan 25, 2024
AlterUnknownPointer works by converting the AST node into an operation on the relevant concrete pointer sort. It always converted into an Alter, though, which meant that the overload case, where AlterObject._cmd_tree_from_ast is called with a Create node, didn't work right. Fixes #6716.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlterUnknownPointer works by converting the AST node into an operation
on the relevant concrete pointer sort. It always converted into an
Alter, though, which meant that the overload case, where
AlterObject._cmd_tree_from_ast is called with a Create node, didn't
work right.
Fixes #6716.