Fix some postgres submodule check issues #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
changed the title
aljazerzen
reviewed
Jan 20, 2024
| shell: bash | ||
| run: | | ||
| required_prefix="Update bundled PostgreSQL" | ||
|
|
||
| title="${{ github.event.pull_request.title }}" | ||
| if [[ $title == $required_prefix* ]]; then |
There was a problem hiding this comment.
Ohhh, this was not quoted so it was being interpreted as commands. Strange that it didn't happen before with my PR titles.
I shouldn't have done this in bash.
There was a problem hiding this comment.
The quoting around $title was my first suspicion as well, but that wasn't really it. It not being quoted means it will be expanded as multiple arguments to [[, which might be fine, though I quoted it to be safe.
The big issue was that backquotes are evaluated inside of double quotes, so when I had a PR title with backquotes in it, it got executed.
Fix was to pass it in as an env var.
aljazerzen
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.