Fix issue with schema changes when trigger depends on a rewrite #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies on rewrites, policies, and triggers don't get explicitly tracked as references, but the things they depend on transitively through those do. The dummy expression for rewrites is not the correct type, so if a trigger and a rewrite are being reprocessed in _propagate_if_expr refs at the same time, and the trigger uses the rewrite, and is processed first, then it will error. Fix this by having the rewrite dummy expression have the right type. I've experimented with having rewrites and triggers explicitly tracked as dependencies, but it complicates some code and I don't think it actually fixes any real problems.
msullivan
force-pushed
the
rewrite-issue
branch
from
54190c6 to
046de6c
Compare
aljazerzen
approved these changes
Jan 22, 2024
| @@ -223,7 +233,9 @@ def get_dummy_expr_field_value( | |||
| value: Any, | |||
| ) -> Optional[s_expr.Expression]: | |||
| if field.name == 'expr': | |||
| return s_expr.Expression(text='false') | |||
| pt = self.scls.get_ptr_target(schema) | |||
| text = f'<{pt.get_displayname(schema)}>{{}}' | |||
There was a problem hiding this comment.
So this is just a cast of an empty set to the correct type?
aljazerzen
pushed a commit
that referenced
this pull request
Jan 25, 2024
Dependencies on rewrites, policies, and triggers don't get explicitly tracked as references, but the things they depend on transitively through those do. The dummy expression for rewrites is not the correct type, so if a trigger and a rewrite are being reprocessed in _propagate_if_expr refs at the same time, and the trigger uses the rewrite, and is processed first, then it will error. Fix this by having the rewrite dummy expression have the right type. I've experimented with having rewrites and triggers explicitly tracked as dependencies, but it complicates some code and I don't think it actually fixes any real problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies on rewrites, policies, and triggers don't get explicitly
tracked as references, but the things they depend on transitively
through those do.
The dummy expression for rewrites is not the correct type, so if a
trigger and a rewrite are being reprocessed in _propagate_if_expr refs
at the same time, and the trigger uses the rewrite, and is processed
first, then it will error.
Fix this by having the rewrite dummy expression have the right type.
I've experimented with having rewrites and triggers explicitly tracked
as dependencies, but it complicates some code and I don't think it
actually fixes any real problems.