Fix spurious delete/create of constraints with arguments in migrations #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug here was that `@index` was not populated in the `params` link for concrete constraints by the reflection writer, and so when we reloaded the schema from the database, it came back in an arbitrary order. This bug has been present for a *long* time, as far as I can tell, but we tended to get "lucky" with the order pg returned the params. This is a strictly *forward* fix. It can be cherry-picked but it will only fix things for constraints created once the fix is applied. I'm working on a backward fix as well. Fixes #6699.
elprans
approved these changes
Jan 17, 2024
msullivan
added a commit
that referenced
this pull request
Jan 19, 2024
#6704) The bug here was that `@index` was not populated in the `params` link for concrete constraints by the reflection writer, and so when we reloaded the schema from the database, it came back in an arbitrary order. This bug has been present for a *long* time, as far as I can tell, but we tended to get "lucky" with the order pg returned the params. This is a strictly *forward* fix. It can be cherry-picked but it will only fix things for constraints created once the fix is applied. I'm working on a backward fix as well. Fixes #6699.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug here was that
@indexwas not populated in theparamslinkfor concrete constraints by the reflection writer, and so when we
reloaded the schema from the database, it came back in an arbitrary
order.
This bug has been present for a long time, as far as I can tell, but
we tended to get "lucky" with the order pg returned the params.
This is a strictly forward fix. It can be cherry-picked but it will
only fix things for constraints created once the fix is applied. I'm
working on a backward fix as well.
Fixes #6699.