Skip to content

Commit

Permalink
turn acltype back into unsupported error
Browse files Browse the repository at this point in the history
  • Loading branch information
aljazerzen committed Feb 10, 2025
1 parent 369608d commit 50a1be0
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
1 change: 0 additions & 1 deletion edb/server/dbview/dbview.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ cdef TYPES_SQL_ONLY = immutables.Map({
28: "00000000-0000-0000-0000-000000000104", # xid -> int32
29: "00000000-0000-0000-0000-000000000104", # cid -> int32
194: "00000000-0000-0000-0000-000000000101", # pg_node_tree -> str
1034: "00000000-0000-0000-0000-000000000101", # aclitem -> str
})

cdef next_dbver():
Expand Down
12 changes: 12 additions & 0 deletions tests/test_sql_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -2983,6 +2983,18 @@ async def test_sql_native_query_29(self):
from pg_type limit 1
''')

async def test_sql_native_query_30(self):
# there are pg_catalog types that don't have a binary repr
# so they cannot be sent over edgeql protocol without casting

with self.assertRaisesRegex(
edgedb.UnsupportedFeatureError,
'unsupported SQL type in column',
):
await self.con.query_sql('''
select relacl from pg_class limit 1
''')


class TestSQLQueryNonTransactional(tb.SQLQueryTestCase):

Expand Down

0 comments on commit 50a1be0

Please sign in to comment.