Skip to content

Commit

Permalink
Fix email button background
Browse files Browse the repository at this point in the history 
When passing `None` explicitly, which we are always doing, the fallback
color was not being set. It was also the wrong format considering that
we store them without the leading `#`.
  • Loading branch information
@scotttrinh
scotttrinh committed Nov 22, 2024
1 parent 5111a08 commit 48b8648
Showing 1 changed file with 15 additions and 12 deletions.
27 changes: 15 additions & 12 deletions edb/server/protocol/auth_ext/ui/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -704,8 +704,9 @@ def render_password_reset_email(
app_name: Optional[str] = None,
logo_url: Optional[str] = None,
dark_logo_url: Optional[str] = None,
brand_color: Optional[str] = "#007bff",
brand_color: Optional[str] = "007bff",
) -> email.message.EmailMessage:
brand_color = brand_color if brand_color is not None else "007bff"
msg = email.message.EmailMessage()
msg["To"] = to_addr
msg["Subject"] = "Reset password"
Expand Down Expand Up @@ -839,22 +840,22 @@ def render_password_reset_email(
<tr>
<td
align="center"
bgcolor="{brand_color}"
bgcolor="#{brand_color}"
role="presentation"
style="
border: none;
border-radius: 4px;
cursor: auto;
mso-padding-alt: 10px 25px;
background: {brand_color};
background: #{brand_color};
"
valign="middle"
>
<a
href="{reset_url}"
style="
display: inline-block;
background: {brand_color};
background: #{brand_color};
color: #ffffff;
font-family: open Sans Helvetica, Arial, sans-serif;
font-size: 18px;
Expand Down Expand Up @@ -949,8 +950,9 @@ def render_verification_email(
app_name: Optional[str] = None,
logo_url: Optional[str] = None,
dark_logo_url: Optional[str] = None,
brand_color: Optional[str] = "#007bff",
brand_color: Optional[str] = "007bff",
) -> email.message.EmailMessage:
brand_color = brand_color if brand_color is not None else "007bff"
msg = email.message.EmailMessage()
msg["To"] = to_addr
msg["Subject"] = (
Expand Down Expand Up @@ -1029,22 +1031,22 @@ def render_verification_email(
<tr>
<td
align="center"
bgcolor="{brand_color}"
bgcolor="#{brand_color}"
role="presentation"
style="
border: none;
border-radius: 4px;
cursor: auto;
mso-padding-alt: 10px 25px;
background: {brand_color};
background: #{brand_color};
"
valign="middle"
>
<a
href="{verify_url}"
style="
display: inline-block;
background: {brand_color};
background: #{brand_color};
color: #ffffff;
font-family:
open Sans Helvetica,
Expand Down Expand Up @@ -1112,8 +1114,9 @@ def render_magic_link_email(
app_name: Optional[str] = None,
logo_url: Optional[str] = None,
dark_logo_url: Optional[str] = None,
brand_color: Optional[str] = "#007bff",
brand_color: Optional[str] = "007bff",
) -> email.message.EmailMessage:
brand_color = brand_color if brand_color is not None else "007bff"
msg = email.message.EmailMessage()
msg["To"] = to_addr
msg["Subject"] = "Sign in link"
Expand Down Expand Up @@ -1158,22 +1161,22 @@ def render_magic_link_email(
<tr>
<td
align="center"
bgcolor="{brand_color}"
bgcolor="#{brand_color}"
role="presentation"
style="
border: none;
border-radius: 4px;
cursor: auto;
mso-padding-alt: 10px 25px;
background: {brand_color};
background: #{brand_color};
"
valign="middle"
>
<a
href="{link}"
style="
display: inline-block;
background: {brand_color};
background: #{brand_color};
color: #ffffff;
font-family: open Sans Helvetica, Arial, sans-serif;
font-size: 18px;
Expand Down

0 comments on commit 48b8648

Please sign in to comment.