Skip to content

Commit

Permalink
Don't unconditionally populate 'iterator' aspect in include_rvar
Browse files Browse the repository at this point in the history
That causes us to have lots of incorrect 'iterator' aspects in rvar
maps.  Instead, just properly populate the aspects explicitly at the
one relevant call site.

This might help with #6714.
  • Loading branch information
msullivan committed Jan 30, 2024
1 parent d16f0fe commit 03e4c77
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions edb/pgsql/compiler/dml.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ def merge_iterator(
put_iterator_bond(iterator, select)
relctx.include_rvar(
select, iterator_rvar,
aspects=('source', 'value', iterator.aspect),
path_id=iterator.path_id,
overwrite_path_rvar=True,
ctx=ctx)
Expand Down
2 changes: 1 addition & 1 deletion edb/pgsql/compiler/relctx.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def include_rvar(
Compiler context.
"""
if aspects is None:
aspects = ('value', 'iterator')
aspects = ('value',)
if path_id.is_objtype_path():
if isinstance(rvar, pgast.RangeSubselect):
if pathctx.has_path_aspect(
Expand Down

0 comments on commit 03e4c77

Please sign in to comment.