When image orientation is not UIImageOrientationUp, the scaling doesn't work correctly

[jkrzemie]

Steps to reproduce:

• download the latest code
• launch the demo
• select an image whose orientation is UIImageOrientationUp, zoom-in heavily, crop; everything will work fine
• now select an image whose orientation != UIImageOrientationUp, zoom-in heavily, crop; the crop is misplaced.

The screens below display both flows: first a correct crop, then the misplaced one.

[joshuafeldman]

I confirm that I see this issue as well.

[joshuafeldman]

The problem is in the _calcVisibleRectForCropArea.

The scale width and height variables should look something more like this.

// determine the scales based on original / current sizes
CGFloat scaleWidth = self.imageView.image.size.width / self.imageView.frame.size.width;
CGFloat scaleHeight = self.imageView.image.size.height / self.imageView.frame.size.height;

// factor the zoom scale of the scroll view
scaleWidth *= self.scrollView.zoomScale;
scaleHeight *= self.scrollView.zoomScale;