Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing filename directly in example code #1

Open
hannob opened this issue Oct 12, 2018 · 1 comment · May be fixed by #2
Open

Passing filename directly in example code #1

hannob opened this issue Oct 12, 2018 · 1 comment · May be fixed by #2

Comments

@hannob
Copy link

hannob commented Oct 12, 2018

Your sample tool expects the filename to be passed with -i.

I think this could be made simpler by just accepting a filename, e.g.
ds_storeviewer [path_to]/.DS_Store

Also in case no parameter is given at all you could just try if .DS_Store exists in the current directory with its original filename and parse that.

Furthermore I'd suggest to have the example code as a file itself and not as part of the readme.

@gehaxelt
Copy link
Owner

Hi @hannob ,
thanks for the suggestions! I've opened a PR which should fix the issues.

Do you mind reviewing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants