Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter configuration flag rename for the secrets file? #72

Open
ArKam opened this issue Jun 18, 2024 · 2 comments
Open

Exporter configuration flag rename for the secrets file? #72

ArKam opened this issue Jun 18, 2024 · 2 comments

Comments

@ArKam
Copy link

ArKam commented Jun 18, 2024

Hi team

the exporter currently use the following configuration flag name for the secrets file integration: secrets.static and associated variable: secretsStatic
as in: https://github.com/gebn/bmc_exporter/blob/master/bmc_exporter.go#L82

A better suited name would rather be: secrets.file and associated variable name: secretsFile

I know it's not really a big deal per see, but I think it's a plus for users/operators integration experience.
thanks!

@gebn
Copy link
Owner

gebn commented Jun 23, 2024

Hi @ArKam, thanks for this. The intention was to separate statically-provided secrets from those retrieved via some kind of integration, e.g. HashiCorp Vault. I know of at least one internal fork where a file is used to configure this integration, so --secrets.file would be ambiguous. Perhaps --secrets.static-file?

@ArKam
Copy link
Author

ArKam commented Aug 6, 2024

That would be more explicit yep.

Or local-file and vault-file perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants