You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we decode the command response successfully, we don't need to tear down the session, even if the completion code is non-normal, as the session is still in a good state. We will want to retry in the case of insufficient resources, otherwise return the error up, as we can't move past it. Doing this will invalidate this comment:
bmc_exporter/collector/collector.go
Line 376 in 6275ae2
If we decode the command response successfully, we don't need to tear down the session, even if the completion code is non-normal, as the session is still in a good state. We will want to retry in the case of insufficient resources, otherwise return the error up, as we can't move past it. Doing this will invalidate this comment:
bmc_exporter/collector/collector.go
Line 249 in 6275ae2
Perhaps modify that function to keep returning early iff the context has expired.
The text was updated successfully, but these errors were encountered: