Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

" 1 ;" lines in forward & reverse master file #23

Open
user32000 opened this issue Nov 14, 2017 · 2 comments
Open

" 1 ;" lines in forward & reverse master file #23

user32000 opened this issue Nov 14, 2017 · 2 comments

Comments

@user32000
Copy link

user32000 commented Nov 14, 2017

I've been getting these lines at the beginning and end of both the forward and reverse master file, which leads the DNS server to reject them with error "zone xx.xx/IN not loaded due to errors."

Unfortunately I have no idea how to create a pull request to submit a proposed fix - can you help, please?

@gclayburg
Copy link
Owner

Sure - pull requests are always welcomed here.

I would start with this documentation on how to go about creating one
https://help.github.com/articles/creating-a-pull-request/

Also, could you confirm you are using the latest software in this repo? I seem to recall a few issues have been fixed.

user32000 added a commit to user32000/synology-diskstation-scripts that referenced this issue Nov 14, 2017
No longer copies "1 ;" lines
user32000 added a commit to user32000/synology-diskstation-scripts that referenced this issue Nov 17, 2017
user32000 added a commit to user32000/synology-diskstation-scripts that referenced this issue Nov 17, 2017
@abitgeeky
Copy link

Created PR For this from my fork:
#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants