Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions UI improvements #4594

Open
28 of 34 tasks
stroomdev66 opened this issue Nov 7, 2024 · 1 comment
Open
28 of 34 tasks

Permissions UI improvements #4594

stroomdev66 opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@stroomdev66
Copy link
Member

stroomdev66 commented Nov 7, 2024

  • Users And Groups - You can't change group names
  • Users And Groups - Bottom pane titles should become:
Group <Group Name> is a Member of:
Members of Group <Group Name>:
  • Users And Groups - Make group icon dirty amber, so it is easier to identify

  • Users And Groups - Include descendants in the bottom right pane (greyed out)

  • Users And Groups - Allow selection of the top item from a link on the bottom item(s)

  • Users And Groups - The user created when an account is created ought to get a Full Name or display name added to the user

  • Users And Groups - The user lists ought to show columns for Display Name, Id, Full Name

  • Users And Groups - Add User Group Or External User, drop down is adding all options each time displayed.

  • Users And Groups - Add User Group Or External User should have fields consistent with column names.

  • Users And Groups - Add User Group Or External User should have help icons on the form.

  • Users And Groups - Users And Groups ought to allow sort on all columns

  • Users And Groups - Included disabled users/groups, and show Enabled state column.

  • Users And Groups - Add a user edit dialog (or toggle button) to set enabled state of users (not groups). May only want to set enabled state for OIDC users.

  • Application Permissions - change User or Group heading to Display Name

  • Application Permissions - Add links to jump to groups in top pane or to group membership.

  • Application Permissions - Replace modal popup with 3 pane view.

  • Document Permissions - Show explicit by default

  • Document Permissions - Eye icon to be replaced by Show Explicit, Show Effective, Show All.

  • Document Permissions - Add detail pane to list screen as opposed to permisisons popup

  • Document Permissions - Batch changes ought to provide a summary before apply.

  • Document Permissions - You can't batch remove permissions for a user.

  • Document Permissions - Immediate changes are replaced by Ok, Cancel buttons.

  • Document Permissions - Change dialog has sub titles for items you are applying changes to and which user/group you are changing them for.

  • Document Permissions - Add Apply to all descendants button plus optional impact summary prior to change.

  • Batch Processor Filter Change - Immediate changes are replaced by Ok, Cancel buttons.

  • Batch Processor Filter Change - Batch changes ought to provide a summary before apply.

  • Doc perms modal dialog - Show inherited perms (similar to how app perms shows them), e.g. Sub Sub Group is a member of Sub Group, so it shows perms inherited from Sub Group.

  • Action button column - On the various perms screen tables it would be good to have an action button column (elipses icon) to do actions on the row, e.g. on UserGroups, click on a group then right click to edit the app perms (or goto the app perms scrn). Essentially make it easier for the user to jump to a user/group/permission/etc.

  • Change the App Perms scrn should default to showing all users/grps, not just those with app perms. E.g. I just created a grp and want to give it app perms. Go to scrn and can't see it, not obv why. Same for the doc perms modal.

  • Change the Members in Group pane to optionally show indirect members rather than just the direct members. Probably needs a column to show which group(s) each member directly belongs to. Ability to jump to any of those groups also beneficial.

  • Decide how the QuickFilter and expression tree filter should be presented to the user as they do essentially the same thing but in a different way. The former is better for quickly filtering a list to find something, but the latter is better for doing a complex batch update. Maybe the batch change should be a screen that includes the filter icon, the filtered table and the changes to be made.

  • Create a PathCell so we can specifically render an explorer tree path (i.e. System / Folder A / Folder B), e.g. making the / a different colour and making each path part a clickable thing (either to locate that node in the tree or open the folder). Applies to User Perms Report screen for one.

  • On the User Perms Report screen replace the eye icon with a drop down to toggle between showing all docs, only those with explicit perms, only those with inherited perms and ones with inherited+explicit.

  • Change the User Perms Report screen to sort in a case insensitive way.

@stroomdev66 stroomdev66 added the bug label Nov 7, 2024
@stroomdev66 stroomdev66 added this to the v7.6 milestone Nov 7, 2024
@stroomdev66 stroomdev66 self-assigned this Nov 7, 2024
@at055612
Copy link
Member

at055612 commented Nov 8, 2024

Relates to #4582

at055612 added a commit that referenced this issue Nov 8, 2024
stroomdev66 added a commit that referenced this issue Nov 12, 2024
stroomdev66 added a commit that referenced this issue Nov 12, 2024
at055612 added a commit that referenced this issue Nov 13, 2024
at055612 added a commit that referenced this issue Nov 15, 2024
stroomdev66 added a commit that referenced this issue Nov 15, 2024
stroomdev66 added a commit that referenced this issue Nov 15, 2024
…gchq/stroom into gh-4594_permission_inheritance
at055612 added a commit that referenced this issue Nov 15, 2024
Disable associated test class.
Cross-module migs just won't work.
The above mig is superseded by the migs in 7.6 anyway
at055612 added a commit that referenced this issue Nov 15, 2024
at055612 added a commit that referenced this issue Nov 15, 2024
at055612 added a commit that referenced this issue Nov 28, 2024
…at055612:gchq/stroom into gh-4594-perms-bugs-and-enhancements_7.6
at055612 added a commit that referenced this issue Nov 28, 2024
at055612 added a commit that referenced this issue Nov 28, 2024
stroomdev66 added a commit that referenced this issue Nov 29, 2024
…gchq/stroom into gh-4594-perms-bugs-and-enhancements_7.6
at055612 added a commit that referenced this issue Dec 9, 2024
…at055612:gchq/stroom into gh-4594-perms-bugs-and-enhancements_7.6
at055612 added a commit that referenced this issue Dec 10, 2024
at055612 added a commit that referenced this issue Dec 10, 2024
at055612 added a commit that referenced this issue Dec 11, 2024
at055612 added a commit that referenced this issue Dec 11, 2024
at055612 added a commit that referenced this issue Dec 11, 2024
at055612 added a commit that referenced this issue Dec 13, 2024
at055612 added a commit that referenced this issue Dec 16, 2024
Change parent --> grandparent to grandparent --> parent
at055612 added a commit that referenced this issue Dec 16, 2024
at055612 added a commit that referenced this issue Dec 16, 2024
at055612 added a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants