Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3202 - Make optional stacks redeployable except EKS #3467

Merged
merged 17 commits into from
Oct 15, 2024
Merged

Issue 3202 - Make optional stacks redeployable except EKS #3467

merged 17 commits into from
Oct 15, 2024

Conversation

patchwork01
Copy link
Collaborator

@patchwork01 patchwork01 commented Oct 11, 2024 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • RedeployOptionalStacksST
    • Tested in AWS

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@patchwork01 patchwork01 changed the base branch from develop to 3451-eks-state-machine-logging October 11, 2024 13:16
@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Oct 11, 2024
Base automatically changed from 3451-eks-state-machine-logging to develop October 14, 2024 12:36
@patchwork01 patchwork01 removed the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Oct 14, 2024
@patchwork01 patchwork01 marked this pull request as ready for review October 14, 2024 14:15
@patchwork01 patchwork01 changed the title Issue 3202 - Make optional stacks redeployable Issue 3202 - Make optional stacks redeployable except EKS Oct 14, 2024
@patchwork01 patchwork01 added one-review-required pr-base-for-stacking Base for stacked pull requests (a dependency for others) labels Oct 14, 2024
@rtjd6554 rtjd6554 assigned patchwork01 and unassigned rtjd6554 Oct 15, 2024
@patchwork01 patchwork01 merged commit 03d8a64 into develop Oct 15, 2024
8 checks passed
@patchwork01 patchwork01 deleted the 3202-redeploy-optional-stacks branch October 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtjd6554 rtjd6554 rtjd6554 approved these changes

Assignees

@patchwork01 patchwork01

Labels
one-review-required pr-base-for-stacking Base for stacked pull requests (a dependency for others)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't redeploy persistent EMR cluster or other optional stacks
2 participants
@patchwork01 @rtjd6554