Skip to content

Organise clients module packages #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patchwork01 opened this issue Apr 8, 2025 · 0 comments · Fixed by #4760
Closed

Organise clients module packages #4605

patchwork01 opened this issue Apr 8, 2025 · 0 comments · Fixed by #4760
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Apr 8, 2025

The clients module has a "util" package that contains a lot of code that doesn't seem related to each other. We could break out a lot of these parts into their own packages.

The root package in the module contains a number of query clients which could sit in their own package.

The package sleeper.clients.status.update doesn't seem related to the "status" package it sits under, and could be moved elsewhere or broken up.

All the scripts that call into these clients will need to be updated if we move the classes around.

We can make sure we move the tests to match how we move the production code.

@patchwork01 patchwork01 added this to the 0.31.0 milestone Apr 8, 2025
@patchwork01 patchwork01 modified the milestones: 0.30.1, 0.31.0 Apr 23, 2025
@patchwork01 patchwork01 self-assigned this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant