Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3969 - Rename ingest job status store to tracker #3975

Merged
merged 49 commits into from
Jan 7, 2025
Merged

Issue 3969 - Rename ingest job status store to tracker #3975

merged 49 commits into from
Jan 7, 2025

Conversation

patchwork01
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Covered by existing tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Dec 18, 2024
@patchwork01 patchwork01 force-pushed the 3969-rename-ingest-job-tracker branch from 9211361 to ab7c552 Compare December 18, 2024 14:49
@patchwork01
Move events to core module except IngestJobValidatedEvent
aaefe36
@patchwork01
Move method only used in tests to test
d1284cd
@patchwork01
Move IngestJobValidatedEvent to core module
4e940a4
@patchwork01
Remove IngestJob from IngestJobAcceptedStatus
42776f9
@patchwork01
Remove IngestJob from IngestJobRejectedStatus
8ebbfc3
@patchwork01
Remove IngestJob from IngestJobStartedStatus
7c56409
@patchwork01
Move ingest job status updates to core module
8193468
@patchwork01
Move ingest job tracker to core module
6a18853
@patchwork01
Create IngestJobStatusFromJobTestData
be1a4b8
@patchwork01
Rename test helper
d4ffd1b
@patchwork01
Move ingestAcceptedStatus to IngestJobStatusFromJobTestData
5c14c25
@patchwork01
Move ingestStartedStatus to IngestJobStatusFromJobTestData
b71aec1
@patchwork01
From IngestJob from ingestStartedStatus helper
7d2e268
@patchwork01
Add validatedIngestStartedStatus to IngestJobStatusFromJobTestData
7f3f94d
@patchwork01
Remove IngestJob from ingestFinishedStatus
8f6d452
@patchwork01
Remove IngestJob from ingestFinishedStatusUncommitted
0991ee8
@patchwork01
Fix Javadoc
2f6b1f3
@patchwork01
Remove trailing spaces in Javadoc
5b3c18b
Base automatically changed from 3968-rename-compaction-task-tracker to develop December 19, 2024 08:43
@patchwork01 patchwork01 removed the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Dec 19, 2024
@patchwork01
Adjust bug comment
97195a7
@patchwork01
Clarify job validation event correlation
9044018
@patchwork01
Rename ingestJobAcceptedEventBuilder
ac76663
@patchwork01
Remove usages of IngestJob in validation tests
d132690
@patchwork01
Move new test
f712408
@patchwork01
Remove usages of IngestJob from run ID correlation tests
9601a72
@patchwork01
Remove IngestJob from InMemoryIngestJobStatusStoreTest
1c21c07
@patchwork01
Remove IngestJob from IngestStatusReportScreenTest
73e20e7
@patchwork01
Remove IngestJob from IngestJobStatusInPeriodTest
ed0f0fa
@patchwork01
Move startedIngestJob to IngestJobStatusFromJobTestData
c02f5cd
@patchwork01
Move more methods to IngestJobStatusFromJobTestData
2340ba2
@patchwork01
Move failedIngestJob to IngestJobStatusFromJobTestData
7e866fd
@patchwork01
Remove IngestJob from IngestJobStatusTest
e8224b9
@patchwork01
Rearrange methods in IngestJobStatusTestHelper
eb9bc2a
@patchwork01
Move some methods to IngestJobStatusFromJobTestData
75b2822
@patchwork01
Remove IngestJob from IngestJobStatusTestHelper
62379a2
@patchwork01
Rename IngestJobStatusTestData
e0b407e
@patchwork01
Move ingest job status test code to core module
0348d47
@patchwork01
Remove unused method
6c1ba98
@patchwork01
Rename IngestJobTracker
c3657ea
@patchwork01
Remove more references to status stores
dea683f
@patchwork01 patchwork01 marked this pull request as ready for review January 6, 2025 15:20
@rtjd6554 rtjd6554 assigned patchwork01 and unassigned rtjd6554 Jan 7, 2025
@patchwork01 patchwork01 merged commit 432a1b8 into develop Jan 7, 2025
8 checks passed
@patchwork01 patchwork01 deleted the 3969-rename-ingest-job-tracker branch January 7, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtjd6554 rtjd6554 rtjd6554 approved these changes

Assignees

@patchwork01 patchwork01

Labels
one-review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename ingest job status store to ingest job tracker
2 participants
@patchwork01 @rtjd6554