Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety when interacting with system test deployment in system tests #3947

Open
patchwork01 opened this issue Dec 16, 2024 · 0 comments

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Dec 16, 2024

Background

Split from:

Description

We'd like to ensure that any interactions with the system test cluster and associated resources are done in a thread safe way.

Analysis

The system test cluster and associated resources are currently deployed in SleeperSystemTestExtension.beforeAll. This is actually called many times, once for each test class. We can either make that thread safe, or move it to the initialisation of SystemTestDeploymentContext.

The SystemTestDeploymentContext is held in a static constant for each test type (in memory, LocalStack or deployed), so if we don't mutate anything after that is constructed, it will be thread safe.

We can adjust DeployedSystemTestResources to avoid any mutable fields on the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant