Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State store commit request type with transaction object held directly or in S3 #3901

Open
patchwork01 opened this issue Dec 10, 2024 · 0 comments

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Dec 10, 2024

Background

Split from:

Description

We'd like to introduce a version of StateStoreCommitRequest that holds the transaction object either directly in the message, or with a pointer to S3.

This should let us simplify the flow of the state store committer lambda, and potentially avoid the need for StateStoreCommitter as a separate class. To apply this commit request we would pass it directly to the state store after deserialisation.

Analysis

The commit request could use the same model as the state store method added in the following issue:

We can use that directly in StateStoreCommitter for now, and anticipate removing most of the logic in that class such that it can be removed in the future.

We could include serialisation/deserialisation code that will be necessary for the following issue, or split it out:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant