Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Docker deployment does not run created compaction jobs #3856

Open
patchwork01 opened this issue Dec 4, 2024 · 0 comments
Open

Local Docker deployment does not run created compaction jobs #3856

patchwork01 opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Dec 4, 2024

Description

We have some scripts to deploy Sleeper to Docker with LocalStack, and create and run compactions in that local instance.

Since we added the compaction job dispatch lambda, the scripts to run compactions no longer work. There is no pending queue deployed, so CreateCompactionJobs fails to send batches to be processed by the dispatch lambda.

Steps to reproduce

  1. Run scripts/deploy/localstack/startContainer.sh, follow the instructions in the output to point to LocalStack
  2. Run scripts/deploy/localstack/deploy.sh <instance-id>
  3. Run scripts/deploy/localstack/createCompactionJobs.sh <instance-id>
  4. See error as pending compaction queue does not exist

Expected behaviour

Compaction jobs should be created correctly.

A compaction task should run the jobs when invoked with scripts/deploy/localstack/runCompactionTash.sh.

We could handle this by adding an instance/table property for CreateCompactionJobs to put jobs on the compaction queue directly, and enable this for all LocalStack deployments.

We could test this in a DSL-based test with LocalStackDslTest.

We can also remove the note from the documentation that was added in the following issue:

@patchwork01 patchwork01 added the bug Something isn't working label Dec 4, 2024
@patchwork01 patchwork01 modified the milestones: 0.27.0, 0.30.0 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant