You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our scripts to deploy an instance of Sleeper upload Docker images to AWS ECR before they invoke the AWS CDK to deploy the instance. This is done in the Java class UploadDockerImages. This authenticates to Docker with the AWS CLI.
Description
We'd like to use the AWS ECR Docker Credential Helper to pass login credentials to Docker when uploading images to AWS ECR.
We can adapt the code in UploadDockerImages.upload to attempt to use the credential helper by default. It can associate the credential helper with the repository after it creates each repository.
We can keep the option to use the AWS CLI to log in. We could detect which of these are installed. If the credential helper is not installed, we can fail by default, but allow using the AWS CLI instead based on a command line argument.
We can install the credential helper in the builder Docker image.
The text was updated successfully, but these errors were encountered:
Background
Our scripts to deploy an instance of Sleeper upload Docker images to AWS ECR before they invoke the AWS CDK to deploy the instance. This is done in the Java class
UploadDockerImages
. This authenticates to Docker with the AWS CLI.Description
We'd like to use the AWS ECR Docker Credential Helper to pass login credentials to Docker when uploading images to AWS ECR.
Analysis
Here's the tool we'd like to use:
https://github.com/awslabs/amazon-ecr-credential-helper
We can adapt the code in
UploadDockerImages.upload
to attempt to use the credential helper by default. It can associate the credential helper with the repository after it creates each repository.We can keep the option to use the AWS CLI to log in. We could detect which of these are installed. If the credential helper is not installed, we can fail by default, but allow using the AWS CLI instead based on a command line argument.
We can install the credential helper in the builder Docker image.
The text was updated successfully, but these errors were encountered: