Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't redeploy persistent EMR cluster or other optional stacks #3202

Closed
gaffer01 opened this issue Sep 5, 2024 · 1 comment · Fixed by #3467
Closed

Can't redeploy persistent EMR cluster or other optional stacks #3202

gaffer01 opened this issue Sep 5, 2024 · 1 comment · Fixed by #3467
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gaffer01
Copy link
Member

gaffer01 commented Sep 5, 2024

Description

We can't remove and then redeploy any optional stacks. When you remove an optional stack, the log groups are retained. When you try to add it back in, it fails to deploy because the log groups already exist.

Steps to reproduce

  1. Deploy an instance with the optional stack 'PersistentEMRBulkImportStack'
  2. Use the admin client to remove that stack, and wait for the CDK to run to remove the cluster
  3. Run the admin client again to add that stack back in
  4. See it fails because it attempts to create a log group for the persistent cluster, but the log group already exists.

Expected behaviour

It should be possible to deploy, remove, redeploy, ... the PersistentEMRBulkImportStack.

Background

We have this issue which suggests making the persistent cluster a runtime deployment option, similar to the non-persistent EMR stack. We may choose to do that and that might solve this issue.

We probably have the same issue for all of the optional stacks. We may be able to solve this by always deploying log groups for all optional stacks and then pointing those stacks at those log groups when they are deployed.

We've split out a separate issue to resolve this for bulk import on EKS:

@gaffer01 gaffer01 added the bug Something isn't working label Sep 5, 2024
@gaffer01 gaffer01 added this to the 0.26 milestone Sep 5, 2024
@patchwork01
Copy link
Collaborator

This seems like a more general problem with optional stacks. I think most if not all of the optional stacks include a log group that would cause this problem when it's removed and added back in.

@gaffer01 gaffer01 changed the title Can't redeploy persistent EMR cluster Can't redeploy persistent EMR cluster or other optional stacks Sep 13, 2024
@patchwork01 patchwork01 self-assigned this Oct 11, 2024
@patchwork01 patchwork01 removed this from the 0.26.0 milestone Oct 14, 2024
@patchwork01 patchwork01 added this to the 0.26.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants