Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate indentation & unnecessary semicolons in Checkstyle #1937

Closed
patchwork01 opened this issue Feb 29, 2024 · 0 comments · Fixed by #2008
Closed

Validate indentation & unnecessary semicolons in Checkstyle #1937

patchwork01 opened this issue Feb 29, 2024 · 0 comments · Fixed by #2008
Assignees
@kr565370
Labels
build-pipeline
Milestone
0.22.0

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Feb 29, 2024 •
edited
Loading

Background

We found some cases where indentation and unnecessary semicolons were not checked by Checkstyle:
#1925 (comment)
#1925 (comment)
#1966 (comment)

Description

We can see if we can configure Checkstyle to validate this.

Analysis

See Checkstyle's documentation:

https://checkstyle.sourceforge.io/checks.html
https://checkstyle.sourceforge.io/checks/misc/indentation.html
https://checkstyle.sourceforge.io/checks/coding/unnecessarysemicolonaftertypememberdeclaration.html
@patchwork01 patchwork01 added this to the 0.22.0 milestone Feb 29, 2024
@patchwork01 patchwork01 changed the title Validate indentation levels in Checkstyle Validate indentation & unnecessary semicolons in Checkstyle Mar 6, 2024
@gaffer01 gaffer01 modified the milestones: 0.22.0, 0.23.0 Mar 12, 2024
@kr565370 kr565370 self-assigned this Mar 12, 2024
@kr565370 kr565370 mentioned this issue Mar 12, 2024
Merged
4 tasks
@patchwork01 patchwork01 modified the milestones: 0.23.0, 0.22.0 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kr565370 kr565370

Labels
build-pipeline
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Issue 1937 - Validate indentation and unnecessary semicolons in checkstyle gchq/sleeper
3 participants
@gaffer01 @patchwork01 @kr565370