Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System tests with S3 state store #1358

Closed
patchwork01 opened this issue Sep 22, 2023 · 1 comment
Closed

System tests with S3 state store #1358

patchwork01 opened this issue Sep 22, 2023 · 1 comment
Labels
system-test-module
Milestone
0.20.0

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Sep 22, 2023 •
edited
Loading

Background

We've found a bug in the S3 state store that we could have found with system tests:

Description

We'd like some coverage of the S3 state store in the system tests.

Analysis

We could adapt the current tests to test both, or we could have separate tests.

If we leave this until after changing table properties doesn't require a CDK deployment, then that would mean we can trivially change state store type between tests.
@patchwork01 patchwork01 added enhancement New feature or request system-test-module and removed enhancement New feature or request labels Sep 22, 2023
@patchwork01 patchwork01 added this to the 0.20.0 milestone Sep 22, 2023
@patchwork01
Copy link
Collaborator Author

Closing as this was added to the nightly test suite in PR #1362.

We could revisit this to limit the tests that need to be re-run with the other state store, but this is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system-test-module
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
1 participant
@patchwork01