Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Python Client Logger Strings #1889

Open
PE39806 opened this issue Feb 5, 2025 · 0 comments
Open

Optimise Python Client Logger Strings #1889

PE39806 opened this issue Feb 5, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code

Comments

@PE39806
Copy link
Contributor

PE39806 commented Feb 5, 2025

A large number of the logging statements in the python client incorrectly mix f-strings with string formatting e.g. logger.info(f"Schema %s successfully retrieved from server.", schema_id). This does not break functionality but is sub-optimal and not best-practice.

This presumably comes from an attempt to address logging-fstring-interpolation / W1203 which has resulted in a large number of f-string-without-interpolation / W1309 issues.

Making use of the pylint plugin for VSCode will make these problems easy to identify and fix.

@PE39806 PE39806 added bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant