Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading of concept data #30

Open
stefandesu opened this issue May 7, 2021 · 0 comments
Open

Improve loading of concept data #30

stefandesu opened this issue May 7, 2021 · 0 comments
Labels
cleanup code cleanup, refactoring, testing...

Comments

@stefandesu
Copy link
Member

Currently, when there are too many concepts that are loaded simultaneously, it will fail completely due to the length of the requested URL. This needs to be fixed either here or in cocoda-sdk's getConcepts method.

coli-ana/src/store.js

Lines 30 to 40 in 92ba7e1

async loadConcepts(concepts) {
const toLoad = concepts.filter(c => !this.state[c.uri])
if (toLoad.length) {
const loadedConcepts = await registry.getConcepts({ concepts: toLoad })
for (let concept of loadedConcepts) {
concept._loaded = true
this.state[concept.uri] = concept
}
}
return concepts.map(c => this.getConcept(c) || c)
},

@nichtich nichtich added the cleanup code cleanup, refactoring, testing... label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup, refactoring, testing...
Projects
None yet
Development

No branches or pull requests

2 participants