Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispersive element naming confusion #74

Open
victoriastrait opened this issue May 24, 2022 · 1 comment
Open

Dispersive element naming confusion #74

victoriastrait opened this issue May 24, 2022 · 1 comment

Comments

@victoriastrait
Copy link
Collaborator

It's confusing that the dispersive element for HST, NIRISS, and NIRCam are all different. Maybe call dispersive element dispname throughout, which will be FILTER for HST, PUPIL-FILTER for NIRISS and FILTER-PUPIL for NIRCam, with a function in utils that generates this from a passed Header or ImageHDU

@gbrammer
Copy link
Owner

gbrammer commented Jun 8, 2022

I think that this is now essentially fixed in that utils.get_hst_filter returns the combination {filter}-{disperser} for JWST instruments accounting for the swap between NIRCam and NIRISS WFSS.

However, pipeline.auto_script.load_GroupFLT still doesn't recognize two JWST grisms for a common blocking filter as being processed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants