Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick code style conventions #49

Open
Rangi42 opened this issue Sep 19, 2024 · 4 comments
Open

Pick code style conventions #49

Rangi42 opened this issue Sep 19, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Sep 19, 2024

Since we manually edit the HTML, CSS, and JS here, we should decide on a preferred code style (indentation, line length, JS features to use/avoid, etc). The ones that can be enforced by Prettier should be added to .prettierrc, and other conventions should be documented in a STYLE.md file.

@Rangi42 Rangi42 added the documentation Improvements or additions to documentation label Sep 19, 2024
@SelvinPL
Copy link
Contributor

"printWidth": 100, give it 150 per line - we are not living in middle ages with 1024x768 resolution
also when i can back to work? with such changes you are not making it easy ...

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 19, 2024

Sorry, I'm done now, that was the last of my broad auto-format changes. (I should really be focusing on work-work, lol.)

Can we compromise on 120? Screens/windows aren't always wide enough for 150. (I'm used to 100 from rgbds source.)

@SelvinPL
Copy link
Contributor

SelvinPL commented Sep 19, 2024

120 fixes some strangly looking <a/>, fair enough
could you do?

I'm thinking about about some small changes .. like menu and button size (I think they are too small padding: 4px 16px shoudl fix it also then menubar should be changed from 21 to 24xp)

So I would love if you would do 120 change and I would tweak those stuff

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 19, 2024

Okay! I eventually want to do a broader UI reconsideration/refactor, but should not let myself get distracted by that right now, and if you end up accomplishing what's needed anyway, then great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants