Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the merge from the List #8

Open
avivace opened this issue Jan 3, 2020 · 6 comments
Open

Automate the merge from the List #8

avivace opened this issue Jan 3, 2020 · 6 comments

Comments

@avivace
Copy link
Member

avivace commented Jan 3, 2020

This has been done manually, as a proof of concept. It should be trivially implementable.

@avivace avivace changed the title Automatize the merge from the List Automate the merge from the List Feb 18, 2020
@ISSOtm
Copy link
Member

ISSOtm commented Jan 5, 2022

What needs to be done?

@avivace
Copy link
Member Author

avivace commented Jan 6, 2022

What needs to be done?

The list in this repository is based on the README.md in the awesome-gbdev, but a lot of custom elements are added, such as the video players, the "info" message about the disambiguation GB/GBA etc...

We would need some way to template the base list and "render" it into this way, possibly with commented lines so the one in the awesome-gbdev remains clean (this pontential solution is mentioned in gbdev/awesome-gbdev#203)

@ISSOtm
Copy link
Member

ISSOtm commented Jan 6, 2022

The Markdown could be parsed into a list of lists (categories of entries), and that processed somehow. Replacements like "insert this between category X and Y", "process entry E thusly", etc.

@avivace
Copy link
Member Author

avivace commented Jan 6, 2022

The Markdown could be parsed into a list of lists (categories of entries), and that processed somehow. Replacements like "insert this between category X and Y", "process entry E thusly", etc.

It's an interesting proposal, thanks ISSO. For sure better than keeping unrelated code in the source list (even if commented).

Considering our list is linted by awesome-lint (actually our version of it: https://github.com/gbdev/list-linter) it's already consistent to the point we could do that, but there's still a lot of spare and custom text around that would make it fail.

@ISSOtm
Copy link
Member

ISSOtm commented Jan 6, 2022

I'd suggest trying to go at it anyway, and seeing what hurdles come up. It may be possible to simply ignore these elements, pass them through without any processing, or give them some special treatment as with the rest, for example.

@avivace
Copy link
Member Author

avivace commented Jan 8, 2022

I'd suggest trying to go at it anyway, and seeing what hurdles come up. It may be possible to simply ignore these elements, pass them through without any processing, or give them some special treatment as with the rest, for example.

Ok, but it would be super low priority for me, as manually merging the list is not a big deal anyway and it happens once(maybe twice) a year. Ping me if you have time for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants