Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake helper functions for configuring / generating cmd / conf files #72

Open
scpeters opened this issue Nov 3, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@scpeters
Copy link
Member

scpeters commented Nov 3, 2021

Desired behavior

We currently have a lot of repeated boilerplate code in each library that generates the conf/*.yaml and cmd*.rb files. It would be nice to provide some cmake helper functions. We could install that with ign-tools since it is related to this package.

For example in ign-transport:

and also in ign-plugin

The helper functions should be able to generate separate files for installation and testing.

Alternatives considered

  • We could add cmake helper functions to ign-cmake.
  • We could continue with the current approach that involves lots of duplicate code.

Implementation suggestion

Additional context

@scpeters scpeters added the enhancement New feature or request label Nov 3, 2021
@chapulina chapulina added the help wanted Extra attention is needed label Nov 12, 2021
@harshmahesheka
Copy link

Hey @scpeters, I tried adding macros to ign-tools rather thanign-cmakeas discussed here gazebosim/gz-cmake#225. I added the code in Utils.cmake but it's not working. Other macros in Utils.cmake are also not working (some of which are working are also mentioned in ign-cmake (like ign_add_executable)). Could you provide some examples or guidance on how to proceed?

@harshmahesheka
Copy link

Hey @scpeters, I tried adding macros to ign-tools rather thanign-cmakeas discussed here ignitionrobotics/ign-cmake#225. I added the code in Utils.cmake but it's not working. Other macros in Utils.cmake are also not working (some of which are working are also mentioned in ign-cmake (like ign_add_executable)). Could you provide some examples or guidance on how to proceed?

I figured out that you had to install the required cmake file and include it in ignition-config.cmake.in.I have raised a pr and would love for you and @j-rivero to review it.

@j-rivero
Copy link
Contributor

Sorry for the silence Harsh, I was out some months when this issue/PRs landed. Back to this, seems to me like there was an agreement to move the features to gz-cmake instead of having it in gz-tools. May I have the details of that agreement or the reason why we need to put it under gz-cmake?

@harshmahesheka
Copy link

Sorry for the silence Harsh, I was out some months when this issue/PRs landed. Back to this, seems to me like there was an agreement to move the features to gz-cmake instead of having it in gz-tools. May I have the details of that agreement or the reason why we need to put it under gz-cmake?

There was a discussion on this issue during Gazebo weekly meets, and after that, I was instructed to re-move it to gz-cmake.

@harshmahesheka
Copy link

Hey @j-rivero, any updates on this? I can help if some changes need to be done before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
4 participants