Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models are broken when inserting from Fuel #350

Closed
Reka-Berci-Hajnovics opened this issue Sep 14, 2020 · 9 comments
Closed

Models are broken when inserting from Fuel #350

Reka-Berci-Hajnovics opened this issue Sep 14, 2020 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@Reka-Berci-Hajnovics
Copy link

Reka-Berci-Hajnovics commented Sep 14, 2020

I've tried to drag and drop several models from Fuel, but they're not loaded correctly.
The red hatchback model cannot find the wheel textures, the PR2_SDF17 has some problems at the joint description, and the x4_uav model doesn't give any errors, but it is exploded.
hatchback_ogre2
PR2_SDF17_ogre2
x4_uav_ogre2

I've copied the empty.sdf file in my own folder and changed the rendering to ogre, as described here: #344 (comment)
When I'm running the updated file the ignition collapses as soon as I try to insert any model from Fuel.
ogre_fuel

@chapulina chapulina self-assigned this Sep 14, 2020
@chapulina chapulina added bug Something isn't working migration Helps with migration from Gazebo classic to Ignition labels Oct 5, 2020
@chapulina
Copy link
Contributor

Some problems loading models are issues with the model, others are issues on Ignition. This is the flow to address these issues:

  1. Is it a bug in Ignition, such as a crash or some mesh that's loading incorrectly?
    • Ticket an issue in the appropriate library if there isn't yet an issue for that specific bug.
  2. Is it a problem with the model description itself (i.e. it doesn't follow the guidelines in Tutorial on migrating SDF files from Gazebo classic #400)?

That said, about the specific models you're trying to load:

@chapulina chapulina removed the migration Helps with migration from Gazebo classic to Ignition label Oct 10, 2020
@claireyywang
Copy link
Contributor

claireyywang commented Oct 12, 2020

I was able to reproduce this on Citadel and Dome (both source build) on Bionic 18.04. Though my models look a bit better.

It looks like a sdformat bug.

Here's the terminal output and screenshot:

[Err] [SDFFeatures.cc:720] Asked to create a joint between links [torso_lift_link] as parent and [torso_lift_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_r_finger_tip_link] as parent and [r_gripper_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_l_finger_tip_link] as parent and [r_gripper_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_r_parallel_link] as parent and [r_wrist_roll_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_l_parallel_link] as parent and [r_wrist_roll_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_r_parallel_link] as parent and [r_gripper_r_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_l_parallel_link] as parent and [r_gripper_l_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [r_gripper_r_finger_tip_link] as parent and [r_gripper_l_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_r_finger_tip_link] as parent and [l_gripper_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_l_finger_tip_link] as parent and [l_gripper_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_r_parallel_link] as parent and [l_wrist_roll_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_l_parallel_link] as parent and [l_wrist_roll_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_r_parallel_link] as parent and [l_gripper_r_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_l_parallel_link] as parent and [l_gripper_l_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:720] Asked to create a joint between links [l_gripper_r_finger_tip_link] as parent and [l_gripper_l_finger_tip_link] as child, but the child link already has a parent joint of type [RevoluteJoint].

dark_pr2

@chapulina
Copy link
Contributor

Thanks for checking @claireyywang . I think there are 2 separate issues. I also get the error messages, but I don't see any broken behaviour on the robot, pressing play all the joints seem to be in place.

The most pressing issue are the distorted meshes, and I'm not sure how to reproduce that.

@Reka-Berci-Hajnovics
Copy link
Author

Some problems loading models are issues with the model, others are issues on Ignition. This is the flow to address these issues:

  1. Is it a bug in Ignition, such as a crash or some mesh that's loading incorrectly?

    • Ticket an issue in the appropriate library if there isn't yet an issue for that specific bug.
  2. Is it a problem with the model description itself (i.e. it doesn't follow the guidelines in Tutorial on migrating SDF files from Gazebo classic #400)?

That said, about the specific models you're trying to load:

I'm using Ignition Citadel, Ubuntu 20.04, and my graphics card is: NVIDIA Corporation GP106BM [GeForce GTX 1060 Mobile 6GB]

@azeey
Copy link
Contributor

azeey commented Oct 13, 2020

The distorted meshes appear to be similar to osrf/subt#438. Can you try testing with the instructions in this or this comments?

The [Err] [SDFFeatures.cc:720] Asked to create a joint between links [torso_lift_link] as parent and [torso_lift_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint]. errors are most likely due to the fact that ign-gazebo doesn't currently support kinematic loops with DART.

@chapulina
Copy link
Contributor

Oh so this is another locale issue. Here are other related issues: gazebosim/gz-rendering#101, gazebosim/gz-rendering#136

@claireyywang
Copy link
Contributor

@anindex fyi

@Reka-Berci-Hajnovics
Copy link
Author

Reka-Berci-Hajnovics commented Oct 14, 2020

The distorted meshes appear to be similar to osrf/subt#438. Can you try testing with the instructions in this or this comments?

The [Err] [SDFFeatures.cc:720] Asked to create a joint between links [torso_lift_link] as parent and [torso_lift_motor_screw_link] as child, but the child link already has a parent joint of type [RevoluteJoint]. errors are most likely due to the fact that ign-gazebo doesn't currently support kinematic loops with DART.

I've tried to run Ignition with an english locale like suggested in the links above and it worked! Thanks!
I haven't changed the whole system locale I just used the following command to run Ignition:

LC_ALL=C LANG=C ign gazebo empty.sdf

I still receive some errors, but the meshes are rendered properly.
fuel_model

@chapulina
Copy link
Contributor

Closing this issue. Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants