diff --git a/src/Commands/Base/GetDiagnostics.cs b/src/Commands/Base/GetDiagnostics.cs index 58d66447a..da45edc45 100644 --- a/src/Commands/Base/GetDiagnostics.cs +++ b/src/Commands/Base/GetDiagnostics.cs @@ -64,7 +64,7 @@ void FillCurrentSite(Diagnostics result) void FillNewerVersionAvailable(Diagnostics result) { var versionAvailable = VersionChecker.GetAvailableVersion(); - if (versionAvailable != null && VersionChecker.IsNewer(versionAvailable.Version)) + if (versionAvailable != null && VersionChecker.IsNewer(versionAvailable.SemanticVersion)) { result.NewerVersionAvailable = versionAvailable.ToString(); } diff --git a/src/Commands/Utilities/VersionChecker.cs b/src/Commands/Utilities/VersionChecker.cs index 238e47f02..decce23e4 100644 --- a/src/Commands/Utilities/VersionChecker.cs +++ b/src/Commands/Utilities/VersionChecker.cs @@ -5,6 +5,7 @@ using System.Net.Http; using System.Net.Http.Headers; using System.Reflection; +using System.Text.Json.Serialization; using System.Xml; using System.Xml.Linq; @@ -73,7 +74,7 @@ public static void CheckVersion(PSCmdlet cmdlet) if (onlineVersion != null) { - if (IsNewer(onlineVersion.Version)) + if (IsNewer(onlineVersion.SemanticVersion)) { if (cmdlet != null) { @@ -229,7 +230,15 @@ public static PnPVersionResult GetAvailableVersion() public class PnPVersionResult { - public SemanticVersion Version { get; set; } + public string Version { get; set; } + public SemanticVersion SemanticVersion + { + get + { + SemanticVersion.TryParse(Version, out SemanticVersion result); + return result; + } + } public string Message { get; set; } } } \ No newline at end of file