Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the naive_fusion functions by show_overlaps and respect_probs #221

Open
gatoniel opened this issue Nov 3, 2022 · 2 comments
Open

Comments

@gatoniel
Copy link
Owner

gatoniel commented Nov 3, 2022

The functions are too complex as the flake8 complexity was now raised to 17. This is due to the constant if statements for show_overlaps and respect_probs. The functions should be separated in different functions so that the if statements are in the very beginning and not within each step of the while-loop.

@gatoniel
Copy link
Owner Author

gatoniel commented Nov 5, 2022

Also add numba @jit in order to speed up stuff.

@gatoniel
Copy link
Owner Author

gatoniel commented Nov 5, 2022

Another speed up could be reached by rewriting the polygon_to_label and polyhedron_to_label functions from stardist without there constant type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant