Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting and XPUB bug #113

Open
ty-everett opened this issue Jan 29, 2019 · 0 comments
Open

Rate limiting and XPUB bug #113

ty-everett opened this issue Jan 29, 2019 · 0 comments
Labels
bug Something isn't working XPUB

Comments

@ty-everett
Copy link
Contributor

Some sort of API rate limiting should be imposed somehow to prevent excessive spam.

Perhaps a small PoW with each request, or after a certain number of requests per minute with the same IP.

On the same note, with merchants who use XPUB, it is possible to send more than 20 requests to /pay without the intention of ever paying the invoices. In these cases, 20 XPUB addresses are missed in a row which exceeds the max receipt gap in most BIP44 wallets.

This is tricky, but maybe we could do a mod-20 or something (which wouldn't work for extremely high-volume merchants), or re-use addresses that belong to invoices that haven't been paid in a while.

@ty-everett ty-everett added bug Something isn't working XPUB labels Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working XPUB
Projects
None yet
Development

No branches or pull requests

1 participant